5 Feb 2024 23:29:10 brian m. carlson <sandals@xxxxxxxxxxxxxxxxxxxx>: > On 2024-02-05 at 20:12:10, Tobias Boesch wrote: >> >> .desktop file proposal >> >> [Desktop Entry] >> Name=git gui > > I don't know whether this is the official name of the project or not. > Perhaps someone else can comment on what the capitalization and > punctuation of this entry should be. > >From the official documentation [1] it reads "git-gui" [1] https://git-scm.com/docs/git-gui >> Comment=A portable graphical interface to Git >> Exec=/bin/bash -c 'if [[ "$0" = "/bin/bash" ]]; then git gui; else cd >> "$0" && git gui; fi' %F > > It's not guaranteed that bash even exists on the system, let alone that > it's in /bin. For example, this wouldn't work on most of the BSDs. > This would need to be templated using SHELL_PATH and written in POSIX > sh (e.g., no `[[`). > I see. I'll try to look into it. If someone knows how to do that let me know. >> Icon=/usr/share/git-gui/lib/git-gui.ico > > This would also need to be given an appropriate location based on the > build parameters. > Is it about the build parameters of the build of git(-gui), or about the downstream distros are building? So git leaves this empty and the packagers full this out? >> Type=Application >> Terminal=false >> Categories=Development; >> >> >> I think upstream has any interest to add this. Therefore I ask here." >> >> ------------------------- >> >> The arch package maintainer proposed to try to to add this to upstream >> before just putting it into the arch package. >> Here I am asking if it could be added to git. > > If you wanted to send a suitable patch for the file such that it were > appropriately built as part of the build process and installed, then we > could probably accept it. Such patches are usually created by using > `git format-patch` on one or multiple commits and then sent using `git > send-email`. You can take a look at `Documentation/SubmittingPatches` > for more details. > That is the plan. I don't know if I get the installation part fine for testing it, but sending a patch should be possible. Sure. > I think such functionality would be generally useful, and probably be > beneficial to a wide variety of distributors. > -- Nice to hear. Thanks
