On 04/10/21 08:39PM, Sashank Bandi wrote: > On Mon, Oct 4, 2021 at 1:26 PM Pratyush Yadav <me@xxxxxxxxxxxxxxxxx> wrote: > > Sorry, I couldn't find time to catch up on this because its been busy at > > $DAYJOB. > Well, I hope you got a little time for this thread. > > > Anyway, git-gui does have some basic dark mode support, though I have > > seen reports that it does not work very well. You can change the Tk > > theme and it should enable dark mode on git-gui as well. See [0] for > > some more info. I am not very familiar with how Tk theming would work on > > Windows. > I am not even familiar with Tcl/Tk language itself. But from what I > have found, the Tk uses "vista" theme which is Windows-only default > theme. Does the Windows installation come with any other themes? You can use `ttk::style theme names` to list all available themes. > > > I think it would be nice if we can have a theme picker in the options > > menu though, so that is something you might want to look into. > Yes, I thought of adding a menu between "Tools" and "Help". It will > contain 3 options(system, light, dark) as I said before. I think it would be better to put it in the "options" dialog. > > > [0] https://lore.kernel.org/all/20201008082004.5643-1-serg.partizan@xxxxxxxxx/ > Well, this works only for Linux as Windows doesn't use X Server. But > we can use `ttk::style theme use` for it all over the application. Right. > > My plan is to use a new theme, that is based on default, but can > imitate the look of [0]. I don't mind carrying themes in the git-gui repo since Tk theming support is not very well documented or standardized. But please do be careful of licence compatibility when porting code. > > [0]: https://github.com/TkinterEP/ttkthemes/blob/master/ttkthemes/png/equilux/equilux.tcl -- Regards, Pratyush Yadav
