Re: [PATCH v4] submodule: absorb git dir instead of dying on deinit

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH v4] submodule: absorb git dir instead of dying on deinit
From: Mugdha Pattnaik <mugdhapattnaik@xxxxxxxxx>
Date: Wed, 6 Oct 2021 17:15:26 +0530
Cc: Mugdha Pattnaik via GitGitGadget <gitgitgadget@xxxxxxxxx>, git@xxxxxxxxxxxxxxx, Bagas Sanjaya <bagasdotme@xxxxxxxxx>, Atharva Raykar <raykar.ath@xxxxxxxxx>, Junio C Hamano <gitster@xxxxxxxxx>
In-reply-to: <87sfxpvxcs.fsf@evledraar.gmail.com>
References: <pull.1078.v3.git.git.1630087821429.gitgitgadget@gmail.com> <pull.1078.v4.git.git.1630090303445.gitgitgadget@gmail.com> <87sfxpvxcs.fsf@evledraar.gmail.com>

On Tue, Sep 28, 2021 Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> wrote:
> shouldn't the post-image "! test -d" just be a test_path_is_missing?
> I.e. should this pass if .git is a file? Probably not...

I agree, this test should not pass if .git is a file. I'll change it to
"test_path_is_missing" and send an update to the patch.

References:
- [PATCH v3] submodule: absorb git dir instead of dying on deinit
  - From: Mugdha Pattnaik via GitGitGadget
- [PATCH v4] submodule: absorb git dir instead of dying on deinit
  - From: Mugdha Pattnaik via GitGitGadget
- Re: [PATCH v4] submodule: absorb git dir instead of dying on deinit
  - From: Ævar Arnfjörð Bjarmason

Prev by Date: Re: [INFO] Does Git GUI support Dark Mode on Windows 10 ?
Next by Date: [PATCH v5] submodule: absorb git dir instead of dying on deinit
Previous by thread: Re: [PATCH v4] submodule: absorb git dir instead of dying on deinit
Next by thread: [PATCH v5] submodule: absorb git dir instead of dying on deinit
Index(es):
- Date
- Thread

[Index of Archives] [Linux Kernel Development] [Gcc Help] [IETF Annouce] [DCCP] [Netdev] [Networking] [Security] [V4L] [Bugtraq] [Yosemite] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux SCSI] [Fedora Users]

Powered by Linux