brian m. carlson wrote: > On 2020-12-02 at 16:07:55, Todd Zullinger wrote: >> Indeed. Is it worth mentioning this at all in INSTALL? >> Something like: >> >> - The minimum supported version of docbook-xsl is 1.74. >> + The minimum supported version of docbook-xsl is 1.74. For consistent >> + IDs in the HTML version of the user-manual, 1.79.1 or newer is >> + necessary. >> >> perhaps? > > I don't know that that's even necessary. Anyone doing reproducible > builds is already aware of the required versions in order to do a > reproducible build, and I don't think the average user is going to be > super interested. > > We can if you feel strongly about it, but I don't personally see it as a > big deal. Nah, I definitely don't feel strongly about it. I debated the same point you made -- that those most likely to care about the feature would likely know the versions (perhaps painfully) well. This is a nice change that, conveniently, has all pros and no cons, it seems. I suppose we'd ideally look for a v2 with --stringparam replaced with --param as you noted upthread? And maybe an updated commit message to note that it requires docbook-xsl 1.79.1 to be effective, but older versions gracefully ignore the option? That may be helpful to a future reader who wonders why the requirement wasn't raised. -- Todd
Attachment:
signature.asc
Description: PGP signature
