On 2020-12-01 at 15:41:15, Todd Zullinger wrote: > I think this would raise the minimum supported version of > docbook-xsl to 1.77.1. That might be fine, but we'd > probably want to make sure it doesn't negatively impact > OS/distributions which build the docs as a likely group who > care about reproducible builds. And we'd want to update the > requirement in INSTALL, of course. I don't think that's necessarily the case. I just tested using a random name with another DocBook project I have and it seems to work fine, so there shouldn't be a problem with specifying a name undefined in the stylesheet using xsltproc. If we want this to be effective, then yes, people will need to upgrade. But if they're happy with the old behavior on ancient systems, that shouldn't be a problem. Regardless, I think this is a valuable change, since there's no good reason not to use consistent IDs and at least Debian is switching to all reproducible builds so vendors will appreciate this change. > AFAICT, the generate.consistent.ids param was added in > docbook-xsl-1.77.1 which was released in June 2012. The > commit which added it is 74735098e (New param to support > replacing generate-id() with xsl:number for more consistent > id values., 2011-10-24). If this was released in 2012, we should be fine. > In any case, a minimum of 1.77.1 is present in the supported > releases of CentOS/RHEL and Debian/Ubuntu, at least (most > have 1.79.x). Those are certainly not the only systems Git > cares about; they're simply the systems with which I am at > least mildly familiar. Yeah, CentOS 6 went EOL on November 30, which is very convenient. I'm pretty sure nobody else is using such an old version, and even so, I don't see a backwards compatibility problem with this change. -- brian m. carlson (he/him or they/them) Houston, Texas, US
Attachment:
signature.asc
Description: PGP signature
