On Wed, Dec 2, 2020 at 7:06 PM Junio C Hamano <gitster@xxxxxxxxx> wrote: > > Matheus Tavares Bernardino <matheus.bernardino@xxxxxx> writes: > > > (For some background, I stumbled across this while considering using > > safe_create_leading_directories() for a parallel-checkout patch. But > > then I noticed it adjusts the directories' permissions based on the > > setting and I was worried whether it could be user for checkout.) > > Forgot to respond to this part, but you are correct. > > Anything that tries to replace what is in entry.c must not trigger > adjust_shared_perm() on files and directories in the working tree, > and it is a no-no to call safe_create_leading_directories(). Got it, thanks. I've adjusted the parallel-checkout patch to use the _no_share() scld variant from mt/do-not-use-scld-in-working-tree.
