Emily Shaffer <emilyshaffer@xxxxxxxxxx> writes: > On Mon, Apr 27, 2020 at 02:41:12PM -0700, Junio C Hamano wrote: >> >> Junio C Hamano <gitster@xxxxxxxxx> writes: >> >> > Jonathan Nieder <jrnieder@xxxxxxxxx> writes: >> > >> >> Emily Shaffer wrote: >> >> >> >>> As pointed out in >> >>> https://lore.kernel.org/git/20200425003002.GC17217@xxxxxxxxxx, >> >> >> >> This breadcrumb shouldn't be needed, since the rest of the commit >> >> message already speaks for itself. We can save the future "git log" >> >> reader some time by leaing it out. >> > >> > True. >> >> Well, removing these two lines made the rest non-sentence, so I had >> to rewrite the thing. I am not sure if the educational value warrants >> the mention of compat/ exemption, but it people find it too noisy, >> it can certainly be dropped. > > I've got a reroll to drop the "stdio.h" include too - do you want me to > send it? Your commit message is much nicer than what I came up with on > my end dropping the breadcrumb and generalizing to include stdio.h, so I > can adapt it if you're interested in the reroll. Sure. I already queued it and merged it to 'next', but the result hasn't been pushed out and I am bisecting a test failure in some newish topics that are merged to 'jch' recently, so I do not mind taking a reroll and redoing 'next' before I can push it out today. Thanks.
