On Mon, Apr 27, 2020 at 02:41:12PM -0700, Junio C Hamano wrote: > > Junio C Hamano <gitster@xxxxxxxxx> writes: > > > Jonathan Nieder <jrnieder@xxxxxxxxx> writes: > > > >> Emily Shaffer wrote: > >> > >>> As pointed out in > >>> https://lore.kernel.org/git/20200425003002.GC17217@xxxxxxxxxx, > >> > >> This breadcrumb shouldn't be needed, since the rest of the commit > >> message already speaks for itself. We can save the future "git log" > >> reader some time by leaing it out. > > > > True. > > Well, removing these two lines made the rest non-sentence, so I had > to rewrite the thing. I am not sure if the educational value warrants > the mention of compat/ exemption, but it people find it too noisy, > it can certainly be dropped. I've got a reroll to drop the "stdio.h" include too - do you want me to send it? Your commit message is much nicer than what I came up with on my end dropping the breadcrumb and generalizing to include stdio.h, so I can adapt it if you're interested in the reroll. > > Thanks. > > -- >8 -- > > In the generic parts of the source files, system headers like > <time.h> are supposed to be included indirectly by including > "git-compat-util.h", which manages portability issues (platform > specific compat/ sources are generally exempt from this rule). > > Drop the inclusion. > > Signed-off-by: Emily Shaffer <emilyshaffer@xxxxxxxxxx> > Signed-off-by: Junio C Hamano <gitster@xxxxxxxxx> > --- > bugreport.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/bugreport.c b/bugreport.c > index 089b939a87..e4a7ed3a23 100644 > --- a/bugreport.c > +++ b/bugreport.c > @@ -2,7 +2,6 @@ > #include "parse-options.h" > #include "stdio.h" > #include "strbuf.h" > -#include "time.h" > #include "help.h" > #include "compat/compiler.h" > > -- > 2.26.2-266-ge870325ee8 >
