Emily Shaffer wrote: > As pointed out in > https://lore.kernel.org/git/20200425003002.GC17217@xxxxxxxxxx, This breadcrumb shouldn't be needed, since the rest of the commit message already speaks for itself. We can save the future "git log" reader some time by leaing it out. > we don't > need to include time.h explicitly because it is included (and possibly > managed for portability) by cache.h. Drop the include. > > Signed-off-by: Emily Shaffer <emilyshaffer@xxxxxxxxxx> > --- > Thanks for the observation, Jonathan. > > - Emily > > bugreport.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/bugreport.c b/bugreport.c > index 089b939a87..e4a7ed3a23 100644 > --- a/bugreport.c > +++ b/bugreport.c > @@ -2,7 +2,6 @@ > #include "parse-options.h" > #include "stdio.h" > #include "strbuf.h" > -#include "time.h" Same applies to stdio.h, I believe. Forgive my laziness in not being exhaustive before. Thanks, Jonathan
