On 2020-04-27 at 13:13:12, Carlo Marcelo Arenas Belón wrote: > On Mon, Apr 27, 2020 at 02:05:12PM +0200, Han-Wen Nienhuys wrote: > > > > I don't understand why Git doesn't enforce this, though. Couldn't > > -Wdeclaration-after-statement be added to the Makefile if the compiler > > supported it? > > not sure if that flag will catch it, but from what I recall, that > specific feature was only available in C99 while git's codebase > targets C89 (need to build with --std=gnu89 as some GNU extensions > are already needed). I think we had chosen to preserve this behavior because MSVC didn't support C99. We may wish to change our approach now that MSVC supports a reasonable subset of it and GCC and Clang are available for almost every system out there. I don't think it's unreasonable to expect folks to use a compiler supporting a standard that is now more than two decades old. Of course, that doesn't affect the present series, but it is a thing we should consider. -- brian m. carlson: Houston, Texas, US OpenPGP: https://keybase.io/bk2204
Attachment:
signature.asc
Description: PGP signature
