On Mon, Apr 27, 2020 at 02:05:12PM +0200, Han-Wen Nienhuys wrote: > > I don't understand why Git doesn't enforce this, though. Couldn't > -Wdeclaration-after-statement be added to the Makefile if the compiler > supported it? not sure if that flag will catch it, but from what I recall, that specific feature was only available in C99 while git's codebase targets C89 (need to build with --std=gnu89 as some GNU extensions are already needed). see the "For C programs" section in Documentation/CodingGuidelines for details. Carlo
