Denton Liu <liu.denton@xxxxxxxxx> writes: > The overall scope of these patches is to replace inappropriate uses of > test_must_fail. IOW, we should only allow test_must_fail to run on `git` > and `test-tool`. Ultimately, we will conclude by making test_must_fail > error out on non-git commands. An advance view of the final series can > be found here[1]. > > This is the third part. It focuses on t5*.sh. > > The first part can be found here[2]. The second part can be found here[3]. > > [1]: (may be rebased at any time) https://github.com/Denton-L/git/tree/ready/cleanup-test-must-fail2 > [2]: https://lore.kernel.org/git/cover.1576583819.git.liu.denton@xxxxxxxxx/ > [3]: https://lore.kernel.org/git/cover.1577454401.git.liu.denton@xxxxxxxxx/ I left comments on individual patches, but I think they were all minor. Mostly the series looks good. Thanks. The dl/test-must-fail-fixes-* topics are always fun to read ;-)