The overall scope of these patches is to replace inappropriate uses of test_must_fail. IOW, we should only allow test_must_fail to run on `git` and `test-tool`. Ultimately, we will conclude by making test_must_fail error out on non-git commands. An advance view of the final series can be found here[1]. This is the third part. It focuses on t5*.sh. The first part can be found here[2]. The second part can be found here[3]. [1]: (may be rebased at any time) https://github.com/Denton-L/git/tree/ready/cleanup-test-must-fail2 [2]: https://lore.kernel.org/git/cover.1576583819.git.liu.denton@xxxxxxxxx/ [3]: https://lore.kernel.org/git/cover.1577454401.git.liu.denton@xxxxxxxxx/ Denton Liu (8): t5512: don't use `test_must_fail test_cmp` t5512: generate references with generate_references() t5512: stop losing return codes of git commands t5550: remove use of `test_might_fail grep` t5607: reorder `nongit test_must_fail` t5612: don't use `test_must_fail test_cmp` t5612: stop losing return codes of git commands t5801: teach compare_refs() to accept ! t/t5512-ls-remote.sh | 66 +++++++++++++++++--------------------- t/t5550-http-fetch-dumb.sh | 2 +- t/t5607-clone-bundle.sh | 2 +- t/t5612-clone-refspec.sh | 26 +++++++-------- t/t5801-remote-helpers.sh | 10 ++++-- 5 files changed, 52 insertions(+), 54 deletions(-) -- 2.25.0.114.g5b0ca878e0
