On 15 Mar 2016, at 20:50, Stefan Beller <sbeller@xxxxxxxxxx> wrote: > On Sun, Dec 20, 2015 at 3:19 PM, <larsxschneider@xxxxxxxxx> wrote: >> From: Lars Schneider <larsxschneider@xxxxxxxxx> >> >> "git clone --recursive --depth 1 --single-branch <url>" clones the >> submodules successfully. However, it does not obey "--depth 1" for >> submodule cloning. > > I am about to resend "[RFC/PATCH] clone: add `--shallow-submodules` flag" > which would need tests and I thought about this series as tests. Sounds good, thanks! > I assume patch 2 (fixing a broken && chain in tests) made it through, > but patch 1 and 3 did not? I may pick up ideas from here as it will be > slightly different tests I'd guess. Unfortunately patch 2 ($gmane/282776) did not made it in (I just checked next 104e649). How should we proceed? > > >> +test_expect_failure shallow-clone-recursive ' >> + URL="file://$(pwd | sed "s/[[:space:]]/%20/g")/repo" && > > This would break if the test suite is in a path containing any other white space > than U+0020 such as a tab? (Not that I am encouraging using such paths...) True. I wonder if we really need to use the "file://" URL format here. Maybe a relative would be easier?! Thanks, Lars-- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html