On Sun, Mar 20, 2016 at 01:20:23PM +0100, Laurent Arnoud wrote: > Hi Jeff, > > On Sun, Mar 20, 2016 at 12:29:12AM -0400, Jeff King wrote: > > We have commit.gpgsign, so this makes some sense. Would you want to sign > > _all_ tags created with "git tag", including lightweight tags, or only > > those that would already create a tag object (i.e., annotated tags)? > > Yes those that create a tag object (annotated tags). > All you suggestions make sense and I will prepare a patch v2. That behavior makes more sense to me, but I don't think it's what your patch does (v1 or v2). Perhaps it would make sense to add some tests, both to verify that it is behaving as expected, and to protect that behavior from future changes? -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html