On Sun, Dec 20, 2015 at 3:19 PM, <larsxschneider@xxxxxxxxx> wrote: > From: Lars Schneider <larsxschneider@xxxxxxxxx> > > "git clone --recursive --depth 1 --single-branch <url>" clones the > submodules successfully. However, it does not obey "--depth 1" for > submodule cloning. I am about to resend "[RFC/PATCH] clone: add `--shallow-submodules` flag" which would need tests and I thought about this series as tests. I assume patch 2 (fixing a broken && chain in tests) made it through, but patch 1 and 3 did not? I may pick up ideas from here as it will be slightly different tests I'd guess. > +test_expect_failure shallow-clone-recursive ' > + URL="file://$(pwd | sed "s/[[:space:]]/%20/g")/repo" && This would break if the test suite is in a path containing any other white space than U+0020 such as a tab? (Not that I am encouraging using such paths...) Thanks, Stefan > + echo $URL && > + git clone --recursive --depth 1 --single-branch $URL clone-recursive && > + ( > + cd "clone-recursive" && > + git log --oneline >lines && > + test_line_count = 1 lines > + ) && > + ( > + cd "clone-recursive/submodule" && > + git log --oneline >lines && > + test_line_count = 1 lines > + ) > +' > + > +test_done > -- > 2.5.1 > -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html