On Sun, Mar 20, 2016 at 06:05:34PM +0100, Lars Schneider wrote: > >> +test_expect_failure shallow-clone-recursive ' > >> + URL="file://$(pwd | sed "s/[[:space:]]/%20/g")/repo" && > > > > This would break if the test suite is in a path containing any other white space > > than U+0020 such as a tab? (Not that I am encouraging using such paths...) > True. I wonder if we really need to use the "file://" URL format here. Maybe > a relative would be easier?! I did not look closely at the patch or the tests, but generally we skip shallow-cloning for local-path repositories, as we don't do a regular object transfer at all (and we turn that optimization off for file:// URLs). So presumably it would defeat the purpose of the test. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html