Jacob Keller <jacob.keller@xxxxxxxxx> writes: >> This does make sense but it is an unrelated fix. Perhaps split this >> patch into two? > > That actually is required because otherwise adding a check for argc > would break the things. I could split them and do this first and then > check for argc if you really prefer? It is not "check for argc breaks", it is already broken and by checking for argc you are exposing the breakage, no? So I'd say fix that first and then fix the clone subcommand? > >>> + if (argc) >>> + usage(*git_submodule_helper_usage); >>> + >> >> That asterisk looks very unusual and wanting to be future-proofed >> (i.e. who says that only the first entry matters?). Should't this >> be calling usage_with_options()? >> > > I... didn't know usage_with_options was a thing! Hah. I can fix these up. > > Thanks, > Jake\ -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html