On Mon, Feb 29, 2016 at 11:44 AM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Jacob Keller <jacob.keller@xxxxxxxxx> writes: >> That actually is required because otherwise adding a check for argc >> would break the things. I could split them and do this first and then >> check for argc if you really prefer? > > It is not "check for argc breaks", it is already broken and by > checking for argc you are exposing the breakage, no? > > So I'd say fix that first and then fix the clone subcommand? > Ok, so one patch which fixes the empty string arguments first, then the second patch which adds the (now valid) check? Thanks, Jake -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html