On Mon, Feb 29, 2016 at 9:49 AM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Jacob Keller <jacob.e.keller@xxxxxxxxx> writes: >> Fix the usage description to match implementation. Add an argc check to >> enforce no extra arguments. > > The above sounds very sensible. > Right. >> Fix a bug in the argument passing in >> git-submodule.sh which would pass --reference and --depth as empty >> strings when they were unused, resulting in extra argc after parsing >> options. > > This does make sense but it is an unrelated fix. Perhaps split this > patch into two? > That actually is required because otherwise adding a check for argc would break the things. I could split them and do this first and then check for argc if you really prefer? >> + if (argc) >> + usage(*git_submodule_helper_usage); >> + > > That asterisk looks very unusual and wanting to be future-proofed > (i.e. who says that only the first entry matters?). Should't this > be calling usage_with_options()? > I... didn't know usage_with_options was a thing! Hah. I can fix these up. Thanks, Jake\ -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html