On Mon, Feb 29, 2016 at 10:20 AM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Jacob Keller <jacob.e.keller@xxxxxxxxx> writes: > >> +static int sanitize_submodule_config(const char *var, const char *value, void *data) >> +{ >> + struct strbuf quoted = STRBUF_INIT; >> + struct strbuf *out = data; >> + >> + if (submodule_config_ok(var)) { >> + if (out->len) >> + strbuf_addch(out, ' '); >> + >> + sq_quotef(out, "%s=%s", var, value); > > Can a configuration variable that comes from the original command > line be a boolean true that is spelled without "=true", i.e. can > value be NULL here? > Wouldn't it just be the empty string? I'm not sure. I suppose I can do: sq_quotef(out, "%s=%s, var, value ? value : "") Or something? Thanks Jake -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html