On Mon, Feb 11, 2013 at 1:15 AM, Jonathan Nieder <jrnieder@xxxxxxxxx> wrote: > [administrivia: please don't top-post] > Ethan Reesor wrote: > >> Why not have both? That way there is a way to get a customizable >> response that avoids Junio's complaints and there is a way to do what >> you are trying to achieve. > > What was Junio's complaint? I was referring to the one you recently addressed: On Mon, Feb 11, 2013 at 1:14 AM, Jonathan Nieder <jrnieder@xxxxxxxxx> wrote: > Junio C Hamano wrote: >> Jonathan Nieder <jrnieder@xxxxxxxxx> writes: >>> Junio C Hamano wrote: > >>>> Are you shooting for customizability? >>> >>> Yes, and the ability to generate the message dynamically. >> >> Hmph, if that is the case, wouldn't it be a better direction to give >> a better help for majority of the case where git-shell is used as >> the login shell to allow push and fetch but not for interactive >> access at all? >> >> The first step in that direction may be to give a better canned >> message, followed by a mechanism (perhaps a hook) that lets a >> message customized for the site's needs, no? > > The trouble is that I can't imagine a canned message that everyone > will like. (For example, I quite dislike the current one.) That's > exactly the situation in which some configurability is helpful. > > Some configurability is nice for other situations, anyway. For > example, sites serving a multilingual audience may want the message to > vary based on the user's language (or even source IP). The message > can include a list of available repositories or extra information that > changes over time. And so on. > > Hope that helps, > Jonathan When I made my suggestion, I was tempted to say that both methods (having help return non-zero and allowing a git-configurable response) should be included, but I couldn't think of a reason to include both until you brought your use case back up. -- Ethan Reesor (Gmail) -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html