Re: [Gimp-developer] Extending GPConfig (was: Should the checkerboard be linked to the window or to the image?)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Sep 02, 2004 at 08:08:23PM +0200, Michael Natterer wrote:
> struct _GPConfig
> {
>   guint32  version;
>   guint32  tile_width;
>   guint32  tile_height;
>   gint32   shm_ID;
>   gdouble  gamma;
>   gint8    install_cmap;
>   gint8    show_tool_tips;
>   gint32   min_colors;
>   gint32   gdisp_ID;
>   gchar   *app_name;
>   gchar   *wm_class;
>   gchar   *display_name;
>   gint32   monitor_number;
> };
> 
> I see two options: 
> 
> - using the place "gdouble gamma" uses.
> - using the two unused bytes after "gint8 show_tool_tips".
> 
> I'd suggest we do both and change the struct to:
> 
> struct _GPConfig
> {
>   guint32  version;
>   guint32  tile_width;
>   guint32  tile_height;
>   gint32   shm_ID;
>   gint8    gimp_reserved_1;
>   gint8    gimp_reserved_2;
>   gint8    gimp_reserved_3;
>   gint8    gimp_reserved_4;
>   gint8    gimp_reserved_5;
>   gint8    gimp_reserved_6;
>   gint8    gimp_reserved_7;
>   gint8    gimp_reserved_8;
>   gint8    install_cmap;
>   gint8    show_tool_tips;
>   gint8    gimp_reserved_9;
>   gint8    gimp_reserved_10;
>   gint32   min_colors;
>   gint32   gdisp_ID;
>   gchar   *app_name;
>   gchar   *wm_class;
>   gchar   *display_name;
>   gint32   monitor_number;
> };
> 
> Which should be binary compatible on all platforms.

Sounds good, and gimp_gamma should return 1.0 always (and be marked as
deprecated).

-Yosh

[Index of Archives]     [Video For Linux]     [Photo]     [Yosemite News]     [gtk]     [GIMP for Windows]     [KDE]     [GEGL]     [Gimp's Home]     [Gimp on GUI]     [Gimp on Windows]     [Steve's Art]

  Powered by Linux