Re: #2204: [gimp-bug] Smudge tool paints with black on the edge of a picture

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Package: gimp
Version: 1.1.9

Tomas Mraz <tomm@xxxxxxxxxx> reports that using the
smudge tool near the edge of images introduces dark
colors not in the original image. Larger brushes,
working in image corners, or working constantly near
edges enhance the effect. I've seen that that smudging
must commence at the edge of an image to manifest
the bug; beginning a smudge such that the currently
selected brush is completely in the image does not
cause the effect to appear.

The behavior largely seems to stem from how
smudge_init() [smudge.c CVS 1.8] initializes an
accumulation buffer.

I've submitted a patch that modifies smudge_init()
and its wholly-owned subroutine smudge_allocate_accum_buffer(),
both in  smudge.c [CVS 1.8].  In the patch, smudge_init() now queries
gimp_drawable_get_color_at() at the center
of the current brush, which is always on canvas and
which is likely to be colored more appropriately than
the by-fiat color black. This, of course, is a heuristic
assumption, but seems a reasonable choice in testing
I've done here.

gimp-gosgood-990925-0.patch contains proposed solution.
See gimp-gosgood-990925-0.patch.README for full remarks.

Garry R. Osgood




[Index of Archives]     [Video For Linux]     [Photo]     [Yosemite News]     [gtk]     [GIMP for Windows]     [KDE]     [GEGL]     [Gimp's Home]     [Gimp on GUI]     [Gimp on Windows]     [Steve's Art]

  Powered by Linux