On Thu, Aug 25, 2022 at 10:42:42PM +0800, Zorro Lang wrote: > On Wed, Aug 24, 2022 at 03:32:10PM -0400, Josef Bacik wrote: > > While trying to do > > > > ./check -s <some section> > > > > I was failing because I had a section defined higher than <some section> > > that had TEST_DEV=/some/nonexistent/device, since I was using the other > > section to test an experimental drive. This appears to be because we > > run through all of the sections, and when getting the section config we > > check to see if it's valid, and in this case the section wasn't valid. > > > > The section I was actually trying to use was valid however. Fix check > > to see if the section we're trying to run is in our list of sections to > > run first, and then if it is get the config at that point. > > > > Signed-off-by: Josef Bacik <josef@xxxxxxxxxxxxxx> > > --- > > May you provide any specific config examples to clarify what kind of issue > you feel wrong, and what kind of usage you hope to support :) Hi Josef, Although you didn't reply this email, but I think I might hit similar problem with you recently when I tried to do a btrfs test. I wrote a config.file likes: [default] export TEST_DEV=/dev/sda5 export TEST_DIR=/mnt/test export SCRATCH_DEV_POOL="/dev/mapper/testvg-scratchdev1 /dev/mapper/testvg-scratchdev2 /dev/mapper/testvg-scratchdev3 /dev/mapper/testvg-scratchdev4 /dev/mapper/testvg-scratchdev5" export SCRATCH_MNT=/mnt/scratch [logdev] export TEST_DEV=/dev/sda5 export TEST_DIR=/mnt/test export SCRATCH_DEV=/dev/sda3 export SCRATCH_MNT=/mnt/scratch export USE_EXTERNAL=yes export SCRATCH_LOGDEV=/dev/loop0 And run: # ./check -s default btrfs/275 Then I hit: SECTION -- default FSTYP -- btrfs PLATFORM -- Linux/x86_64 hp-xxxxx-xxxx 6.0.0-0.rc4.20220906git53e99dcff61e.32.fc38.x86_64 #1 SMP PREEMPT_DYNAMIC Wed Sep 7 07:51:49 UTC 2022 MKFS_OPTIONS -- /dev/mapper/testvg-scratchdev1 MOUNT_OPTIONS -- -o context=system_u:object_r:root_t:s0 /dev/mapper/testvg-scratchdev1 /mnt/scratch btrfs/275 2s ... 4s Ran: btrfs/275 Passed all 1 tests common/config: Error: $SCRATCH_DEV (/dev/sda3) should be unset when $SCRATCH_DEV_POOL (/dev/mapper/testvg-scratchdev1 /dev/mapper/testvg-scratchdev2 /dev/mapper/testvg-scratchdev3 /dev/mapper/testvg-scratchdev4 /dev/mapper/testvg-scratchdev5) is set SECTION -- default ========================= Ran: btrfs/275 Passed all 1 tests Is that the problem what you said, or you have more problems? Thanks, Zorro > > Thanks, > Zorro > > > check | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/check b/check > > index 0b2f10ed..ad0ab3cf 100755 > > --- a/check > > +++ b/check > > @@ -678,7 +678,6 @@ function run_section() > > > > OLD_FSTYP=$FSTYP > > OLD_TEST_FS_MOUNT_OPTS=$TEST_FS_MOUNT_OPTS > > - get_next_config $section > > > > # Do we need to run only some sections ? > > if [ ! -z "$RUN_SECTION" ]; then > > @@ -708,6 +707,8 @@ function run_section() > > fi > > fi > > > > + get_next_config $section > > + > > mkdir -p $RESULT_BASE > > if [ ! -d $RESULT_BASE ]; then > > echo "failed to create results directory $RESULT_BASE" > > -- > > 2.26.3 > >
