On Fri, Sep 23, 2022 at 08:02:10AM +0000, Johannes Thumshirn wrote: > On 22.09.22 17:42, Zorro Lang wrote: > >> --- /dev/null > >> +++ b/common/zbd > > I don't like this abbreviation :-P If others don't open this file and read the > > comment in it, they nearly no chance to guess what's this file for. > > > > zbd is a well known abbreviation for zoned block devices. I think most > people in storage and filesystems know it. OK, but we haven't been that "a single character is worth a thousand pieces of gold", so we can use a longer name, likes common/zone, common/zoned, common/zoned_block, common/zoned_device or something likes that. Anyway, that's just my personal opinion, if most of people prefer using "common/zbd", I'm fine to have that :) But I hope you can move all zoned block device related helpers to the new common file if you'd like to bring in this file, likes what Darrick did in: commit 67afd5c742464607994316acb2c6e8303b8af4c5 Author: Darrick J. Wong <djwong@xxxxxxxxxx> Date: Tue Aug 9 14:00:46 2022 -0700 common/rc: move ext4-specific helpers into a separate common/ext4 file Thanks, Zorro > >