[PATCH] fstests: get section config after RUN_SECTION checks

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



While trying to do

./check -s <some section>

I was failing because I had a section defined higher than <some section>
that had TEST_DEV=/some/nonexistent/device, since I was using the other
section to test an experimental drive.  This appears to be because we
run through all of the sections, and when getting the section config we
check to see if it's valid, and in this case the section wasn't valid.

The section I was actually trying to use was valid however.  Fix check
to see if the section we're trying to run is in our list of sections to
run first, and then if it is get the config at that point.

Signed-off-by: Josef Bacik <josef@xxxxxxxxxxxxxx>
---
 check | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/check b/check
index 0b2f10ed..ad0ab3cf 100755
--- a/check
+++ b/check
@@ -678,7 +678,6 @@ function run_section()
 
 	OLD_FSTYP=$FSTYP
 	OLD_TEST_FS_MOUNT_OPTS=$TEST_FS_MOUNT_OPTS
-	get_next_config $section
 
 	# Do we need to run only some sections ?
 	if [ ! -z "$RUN_SECTION" ]; then
@@ -708,6 +707,8 @@ function run_section()
 		fi
 	fi
 
+	get_next_config $section
+
 	mkdir -p $RESULT_BASE
 	if [ ! -d $RESULT_BASE ]; then
 		echo "failed to create results directory $RESULT_BASE"
-- 
2.26.3




[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux