Hi, On 15 March 2018 at 17:02, Kris Davis <Kris.Davis@xxxxxxx> wrote: > Sorry I've been unavailable for a couple of weeks. > > Chose #2: > 2. Keep one script but somehow let it contain non-weighted vs weighted paths. > > I merged the changes from my "no weighted" version with the original script, and added a "--noweight" option. I didn't try to combined the file i/o methods, but just split the "main" function latter operation into "output_interval_data" and "output_weighted_interval_data", for lack of more creative names :). > > Below is the new patch By some chance you wouldn't have this up in a github repo too? GMail's web client seems to do unspeakable whitespace changes to patches (I wound up copying and pasting from https://www.spinics.net/lists/fio/msg06872.html in the end). I still get grumbles about trailing whitespace from git but again I don't know if that's just how I got the patch. Could you update the tool's manpage (tools/hist/fiologparser_hist.py.1) with your changes too? Shouldn't __HIST_COLUMNS be changed depending on whether micro or nanoseconds are being used? It looks like it matches FIO_IO_U_PLAT_NR which is calculated by (1 << FIO_IO_U_PLAT_BITS) * FIO_IO_U_PLAT_GROUP_NR which for fio-3.5 is (1 << 6) * 29 = 1856 . Commit https://github.com/axboe/fio/commit/d6bb626ef37d3905221ade2887b422717a07af09 seems to be the one that changed the value of FIO_IO_U_PLAT_GROUP_NR ... Beyond that a simple run worked for me with the following: cd /tmp/ fio --name=test --rw=read --runtime=5s --time_based --filename=/tmp/fio.tmp --size=1M --write_hist_log=test --log_hist_msec=100 fiologparser_hist.py test_clat_hist.1.log fiologparser_hist.py --noweight --percentiles 0,1,50 test_clat_hist.1.log -- Sitsofe | http://sucs.org/~sits/ -- To unsubscribe from this list: send the line "unsubscribe fio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
