question about rpmlint E: non-executable-script

[chedi toueiti <chedi.toueiti@xxxxxxxxx>]

Hi,

I'm reviewing a new package

https://bugzilla.redhat.com/show_bug.cgi?id=1810902

this package have bash scripts that are under /usr/lib and starting with a shebang, rpmlint is detecting the error

E: non-executable-script

rpkg-macros.noarch: E: non-executable-script /usr/lib/rpkg.macros.d/all.bash 644 /bin/bash 
rpkg-macros.noarch: E: non-executable-script /usr/lib/rpkg.macros.d/git.bash 644 /bin/bash 
rpkg-macros.noarch: E: non-executable-script /usr/lib/rpkg.macros.d/library/log.bash 644 /bin/bash 
rpkg-macros.noarch: E: non-executable-script /usr/lib/rpkg.macros.d/library/output.bash 644 /bin/bash 
rpkg-macros.noarch: E: non-executable-script /usr/lib/rpkg.macros.d/library/query.bash 644 /bin/bash 
rpkg-macros.noarch: E: non-executable-script /usr/lib/rpkg.macros.d/library/utils.bash 644 /bin/bash 

The author desire to keep the shebang and not set the execution bit as the files are not meant to be executable.

Should I consider the package valid or not in this case.

--

Chedi Toueiti

* Due to the constant fluctuation in customer personalities, we cannot be responsible for the mental stability of any one member of our staff.

** My opinions may have changed, but not the fact that I am right.

*** I always try to go the extra mile at work, but my boss always finds me and brings me back.

_______________________________________________
packaging mailing list -- packaging@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to packaging-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/packaging@xxxxxxxxxxxxxxxxxxxxxxx