On Mon, Mar 9, 2020 at 8:54 AM chedi toueiti <chedi.toueiti@xxxxxxxxx> wrote: > > Hi, > > I'm reviewing a new package > https://bugzilla.redhat.com/show_bug.cgi?id=1810902 > > this package have bash scripts that are under /usr/lib and starting with a shebang, rpmlint is detecting the error > > E: non-executable-script > > rpkg-macros.noarch: E: non-executable-script /usr/lib/rpkg.macros.d/all.bash 644 /bin/bash > rpkg-macros.noarch: E: non-executable-script /usr/lib/rpkg.macros.d/git.bash 644 /bin/bash > rpkg-macros.noarch: E: non-executable-script /usr/lib/rpkg.macros.d/library/log.bash 644 /bin/bash > rpkg-macros.noarch: E: non-executable-script /usr/lib/rpkg.macros.d/library/output.bash 644 /bin/bash > rpkg-macros.noarch: E: non-executable-script /usr/lib/rpkg.macros.d/library/query.bash 644 /bin/bash > rpkg-macros.noarch: E: non-executable-script /usr/lib/rpkg.macros.d/library/utils.bash 644 /bin/bash > > > The author desire to keep the shebang and not set the execution bit as the files are not meant to be executable. > > Should I consider the package valid or not in this case. > In the current case, this is not acceptable. These are the two choices I would offer: * Those should be in /usr/share if they are architecture-independent scripts that aren't executed (shebangs should be purged) * Those should be in /usr/libexec in any other case -- 真実はいつも一つ！/ Always, there's only one truth! _______________________________________________ packaging mailing list -- packaging@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to packaging-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/packaging@xxxxxxxxxxxxxxxxxxxxxxx
