[Bug 451582] Review Request: kvirc - themeable qt based irc client

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=451582





--- Comment #5 from manuel wolfshant <wolfy@xxxxxxxxxxxxxxxxxx>  2008-09-29 17:15:44 EDT ---
uhm, and rpmlint could be made happier too:
rpmlint of kvirc-debuginfo:
kvirc-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/kvirc-3.4.0/src/kvirc/ui/kvi_modew.h
kvirc-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/kvirc-3.4.0/src/kvirc/ui/kvi_modew.cpp
kvirc-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/kvirc-3.4.0/src/modules/help/index.h
kvirc-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/kvirc-3.4.0/src/modules/help/index.cpp

rpmlint of kvirc:
kvirc.x86_64: W: devel-file-in-non-devel-package
/usr/include/kvirc/3.4.0/kvi_ircurl.h
kvirc.x86_64: W: devel-file-in-non-devel-package
/usr/include/kvirc/3.4.0/kvi_kvs_treenode_extendedscopevariable.h
kvirc.x86_64: W: devel-file-in-non-devel-package
/usr/include/kvirc/3.4.0/kvi_kvs_treenode_specialcommandclass.h
kvirc.x86_64: E: script-without-shebang
/usr/share/kvirc/3.4/modules/libkvisharedfileswindow.la
kvirc.x86_64: E: script-without-shebang
/usr/share/kvirc/3.4/modules/libkviclock.la
kvirc.x86_64: E: script-without-shebang
/usr/share/kvirc/3.4/modules/libkvireguser.la
kvirc.x86_64: W: devel-file-in-non-devel-package
/usr/include/kvirc/3.4.0/kvi_valuelist.h
kvirc.x86_64: E: script-without-shebang
/usr/share/kvirc/3.4/modules/libkvidialog.la
kvirc.x86_64: E: zero-length /usr/share/kvirc/3.4/locale/notifier_pt_BR.mo
kvirc.x86_64: W: devel-file-in-non-devel-package
/usr/include/kvirc/3.4.0/kvi_url.h
kvirc.x86_64: E: zero-length
/usr/share/kvirc/3.4/locale/filetransferwindow_it.mo
kvirc.x86_64: E: zero-length /usr/share/kvirc/3.4/locale/about_hr.mo
kvirc.x86_64: W: devel-file-in-non-devel-package
/usr/include/kvirc/3.4.0/kvi_tal_mainwindow_qt4.h
kvirc.x86_64: W: devel-file-in-non-devel-package
/usr/include/kvirc/3.4.0/kvi_tal_groupbox_qt4.h
kvirc.x86_64: E: zero-length /usr/share/kvirc/3.4/locale/logview_hu.mo
kvirc.x86_64: W: devel-file-in-non-devel-package
/usr/include/kvirc/3.4.0/kvi_tal_listbox_qt3.h
[...]
 and so on up to
1 packages and 0 specfiles checked; 361 errors, 497 warnings.
All the messages can be grouped in
- W: devel-file-in-non-devel-package /usr/include/kvirc/3.4.0/*.h
- E: zero-length /usr/share/kvirc/3.4/locale/*.mo
- E: script-without-shebang /usr/share/kvirc/3.4/modules/*.la
- W: file-not-in-%lang /usr/share/kvirc/3.4/locale/*.mo

The messages about the locale files are probably related to a missing
gettext-devel BR.

In addition
- the source and doc files (below /usr/include and /usr/share/)  are included
in kvirc.rpm without having their timestamp preserved, which would be nice to
be fixed. And given the very large number of files, I think that you should
consider packaging them separately, in -devel and -doc. Unless all those .h are
needed for runtime, which I doubt
- /usr/include/kvirc/ and /usr/share/kvirc/ are unowned
- lots of docs from the original tarball have not been included. I mean here
the /doc folder (including the license!) + example scripts, the README and FAQ
files and so on

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]