Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=451582 manuel wolfshant <wolfy@xxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wolfy@xxxxxxxxxxxxxxxxxx --- Comment #4 from manuel wolfshant <wolfy@xxxxxxxxxxxxxxxxxx> 2008-09-29 16:57:11 EDT --- Couple of comments / suggestions: %configure --x-includes=/usr/include --x-libraries=/usr/%{libdir} should probably become %configure --x-includes=%{_includedir} --x-libraries=%{_libdir} make should be replaced with make %{?_smp_mflags} (unless there is a known reason to not do it, in which case a comment should be added to the spec) And I think that there are some BRs which are missing (or is this intentional maybe?) because the buildlog says checking for the KDE libraries... "FAILED" (-> kdelibs-devel ?) checking If we can compile and link a small SSL test application... no (-> openssl-devel?) checking for secure connections support... disabled: failed to compile the test program checking for Esound daemon support... disabled by user (-> pulseaudio-esound-compat ?) checking if Arts support is requested... no KDE so no Arts (->arts-devel ?) checking if you want to link to libresolv... no (-> glibc-devel ?) checking if you want to link to libsocket... no checking if you want to link to libnsl... no I left out some other failed checks which seem to require bits that do not exist in Fedora (libXss, audiofile, perl(ExtUtils:Embed)) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review