https://bugzilla.redhat.com/show_bug.cgi?id=2209858 --- Comment #4 from Ryan <errornointernet@xxxxxxxx> --- Hello, Thanks for the recommendations :) Here's the full list of changes I've made: 1. Included all the licenses in all the files (Fedora Review) 2. Used `%{url}/archive/v%{version}/%{name}-%{version}.tar.gz` as the source 3. Split BuildRequires onto multiple lines 4. Renamed "g++" dependency to "gcc-c++" (Fedora Review) 5. Split description into shorter lines 6. %build now only contains 2 lines, %cmake and %cmake_build 7. %install now only contains 1 line, %cmake_install New .spec URL: https://download.copr.fedorainfracloud.org/results/errornointernet/timg/fedora-rawhide-x86_64/06151676-timg/timg.spec New .srpm URL: https://download.copr.fedorainfracloud.org/results/errornointernet/timg/fedora-rawhide-x86_64/06151676-timg/timg-1.4.5-5.fc39.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2209858 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202209858%23c4 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
