https://bugzilla.redhat.com/show_bug.cgi?id=2209858 Artur Frenszek-Iwicki <fedora@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora@xxxxxxxxxx --- Comment #5 from Artur Frenszek-Iwicki <fedora@xxxxxxxxxx> --- > License: GPL-2.0 AND GPL-2.0-or-later AND MIT The first item here should be "GPL-2.0-only". https://spdx.org/licenses/GPL-2.0-only.html > %files > %{_mandir}/man1/timg.1.gz Do not assume man pages will be gzipped. Use a wildcard that can match any compression method (including none). https://docs.fedoraproject.org/en-US/packaging-guidelines/#_manpages Another thing is that the upstream repository bundles some third party libraries: - third_party/stb - third_party/qoi Bundling libraries in generally discouraged in Fedora. https://docs.fedoraproject.org/en-US/packaging-guidelines/#bundling Upstream CMakeLists seem to support using system-provided versions of these libraries. stb is available in Fedora as a separate package - you can add "BuildRequires: stb_image-devel stb_image_resize-devel". For qoi, you'd need to either create a new package and submit it for review, or add "Provides: bundled(qoi)". -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2209858 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202209858%23c5 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
