https://bugzilla.redhat.com/show_bug.cgi?id=2213372 --- Comment #7 from Tom Rix <trix@xxxxxxxxxx> --- hipcc.bin really doesn't run by itself, it can not handle an unknown command arg, like -v or -h. So when I was checking it out i could not find out what version of hipcc.bin I was running. When other folks try to do this they will likewise be confused. The setup of clang arguments looks like it duplicates / should go into clang's Toolchain/ Then this would be a passthrough for amd and a wrapper for nvcc. Why is the duplicated clang logic needed ? Maybe hipcc.bin should not be in the normal PATH if it does not behave well ? This introduces other problems so I am not sure. It would be good if hipcc.bin were more polished / less rough. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2213372 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202213372%23c7 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
