https://bugzilla.redhat.com/show_bug.cgi?id=2209858 Petr Menšík <pemensik@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pemensik@xxxxxxxxxx --- Comment #3 from Petr Menšík <pemensik@xxxxxxxxxx> --- I would recommend splitting BuildRequires: on multiple lines. Single line over 200 characters is not nice. Similarly, %description should contain new lines and description with reasonably short lines. Common legacy value is 80 characters per line. A bit more may make sense on modern server, but 120 would be limit even there. GUI tools obtain information from AppStream files, but rpm -q and dnf info present them as preformatted by the author. in %build phase, %cmake has to be used. It provides default build flags to package build. Use %cmake_build and %cmake_install to handle created subdirectory. Own creation of build directory is not necessary, rpm macros will handle that. I would recommend (optional) to use nicer source archives: Source0: %{url}/archive/v%{version}/%{name}-%{version}.tar.gz when spectool -g *.spec is used to fetch them, they are named as timg-1.4.5.tar.gz that way. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2209858 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202209858%23c3 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
