[Bug 1885684] Review Request: rocm-smi - AMD ROCm System Management Interface

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1885684



--- Comment #2 from code@xxxxxxxxxxxxxxxxxx ---
> We generally don't use the trick with package renaming anymore.

Adjusted, thanks.

> The man page needs to go into %{_mandir}/man1/. That's why rpmlint doesn't find the page.

Thanks! A simple typo, now resolved. I’m surprised I didn’t catch it myself. I
also found an error in the regex I was using to alter the generated man page,
and fixed that as well.

> Please also submit that. It might be OK to simply exclude the build for s390x or skip the tests...

OK, I can submit that with s390x tests disabled. Upstream claims the package
should work on s390x, but the test framework is a little… opaque, so it’s hard
to dig into failures if you’re not the upstream maintainer. It might be
possible to get somewhere with an upstream bug report, or not.

----

The updated spec file is at the original link. Here is the new batch of koji
builds:

Fedora 34: https://koji.fedoraproject.org/koji/taskinfo?taskID=52886511
Fedora 33: https://koji.fedoraproject.org/koji/taskinfo?taskID=52886874
Fedora 32: https://koji.fedoraproject.org/koji/taskinfo?taskID=52887198
EPEL8: https://koji.fedoraproject.org/koji/taskinfo?taskID=52886548
EPEL7: https://koji.fedoraproject.org/koji/taskinfo?taskID=52886971

…and the new SRPM:
https://kojipkgs.fedoraproject.org//work/tasks/6750/52886750/rocm-smi-3.8.0-1.fc34.src.rpm.

Thanks for your input.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux