https://bugzilla.redhat.com/show_bug.cgi?id=1885699 Andy Mender <andymenderunix@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+ --- Comment #3 from Andy Mender <andymenderunix@xxxxxxxxx> --- Looks really good. fedora-review picked up 1 thing about the /usr/share/zsh dir: > [ ]: Package must own all directories that it creates. > Note: Directories without known owners: /usr/lib/systemd/user, > /usr/share/zsh, /usr/lib/systemd > Review: Should there not be a Requires on "zsh"? You can do it on package import, of course. The rest is fine. Package approved. Full review below: Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package does not use a name that already exists. Note: A package with this name already exists. Please check https://src.fedoraproject.org/rpms/profile-sync-daemon See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Naming/#_conflicting_package_names - systemd_user_post is invoked in %post and systemd_user_preun in %preun for Systemd user units service files. Note: Systemd user unit service file(s) in profile-sync-daemon See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Scriptlets/#_user_units Review: Per guidelines. Everything in order. ===== MUST items ===== Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Expat License", "Expat License". 47 files have unknown license. Detailed output of licensecheck in /home/amender/rpmbuild/SPECS/profile-sync- daemon/profile-sync-daemon/licensecheck.txt [ ]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/systemd/user, /usr/share/zsh, /usr/lib/systemd Review: Should there not be a Requires on "zsh"? [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [?]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: Reviewer should test that the package builds in mock. [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. Rpmlint ------- Checking: profile-sync-daemon-6.42-1.fc34.noarch.rpm profile-sync-daemon-6.42-1.fc34.src.rpm profile-sync-daemon.noarch: W: spelling-error Summary(en_US) Symlinks -> Slinks profile-sync-daemon.noarch: W: spelling-error Summary(en_US) dirs -> rids, sirs, firs profile-sync-daemon.noarch: W: spelling-error %description -l en_US tmpfs -> temps profile-sync-daemon.noarch: W: spelling-error %description -l en_US symlinking -> unblinking profile-sync-daemon.noarch: W: no-manual-page-for-binary psd-suspend-sync profile-sync-daemon.noarch: W: empty-%postun profile-sync-daemon.src: W: spelling-error Summary(en_US) Symlinks -> Slinks profile-sync-daemon.src: W: spelling-error Summary(en_US) dirs -> rids, sirs, firs profile-sync-daemon.src: W: spelling-error %description -l en_US psd -> pad, pd, psi profile-sync-daemon.src: W: spelling-error %description -l en_US tmpfs -> temps profile-sync-daemon.src: W: spelling-error %description -l en_US symlinking -> unblinking 2 packages and 0 specfiles checked; 0 errors, 11 warnings. Rpmlint (installed packages) ---------------------------- (none): E: no installed packages by name profile-sync-daemon 0 packages and 0 specfiles checked; 0 errors, 0 warnings. Source checksums ---------------- https://github.com/graysky2/profile-sync-daemon/archive/v6.42/profile-sync-daemon-6.42.tar.gz : CHECKSUM(SHA256) this package : d73625b81fa16e30cc4f982a25d8bf0b8697529b11dcff58617172c573f387f4 CHECKSUM(SHA256) upstream package : d73625b81fa16e30cc4f982a25d8bf0b8697529b11dcff58617172c573f387f4 Requires -------- profile-sync-daemon (rpmlib, GLIBC filtered): /bin/sh /usr/bin/bash rsync Provides -------- profile-sync-daemon: profile-sync-daemon -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
