[Bug 1885699] Review Request: profile-sync-daemon - Symlinks and syncs browser profile dirs to RAM thus reducing HDD/SDD calls

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1885699



--- Comment #4 from Artem <ego.cordatus@xxxxxxxxx> ---
(In reply to Andy Mender from comment #3)
> Looks really good. fedora-review picked up 1 thing about the /usr/share/zsh
> dir:
> > [ ]: Package must own all directories that it creates.
> >      Note: Directories without known owners: /usr/lib/systemd/user,
> >      /usr/share/zsh, /usr/lib/systemd
> >      Review: Should there not be a Requires on "zsh"?
> 
> You can do it on package import, of course. The rest is fine. Package
> approved. Full review below:

Thanks! Ill fix this before import. As for '/usr/share/zsh' we can own it or we
can skip this according to this discussion
https://bugzilla.redhat.com/show_bug.cgi?id=1739807#c10
But we should add explicitly 'Requires: systemd' here.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux