https://bugzilla.redhat.com/show_bug.cgi?id=1885684 Bug ID: 1885684 Summary: Review Request: rocm-smi - AMD ROCm System Management Interface Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Assignee: nobody@xxxxxxxxxxxxxxxxx Reporter: code@xxxxxxxxxxxxxxxxxx QA Contact: extras-qa@xxxxxxxxxxxxxxxxx CC: package-review@xxxxxxxxxxxxxxxxxxxxxxx Target Milestone: --- Classification: Fedora Spec URL: https://gitlab.com/musicinmybrain/rocm-smi-rpm/-/raw/master/rocm-smi.spec SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/6769/52876769/rocm-smi-3.8.0-1.fc34.src.rpm Description: AMD ROCm System Management Interface Fedora Account System Username: music This is a command-line tool for clock and temperature management of a ROCm enabled system, i.e., one with an AMD GPU. It does not directly depend on the AMDGPU (open-source) or AMDGPU-PRO (proprietary) GPU driver; instead, it is a monolithic pure-Python script that interacts with any supported GPU via sysfs. Koji build for Fedora 34: https://koji.fedoraproject.org/koji/taskinfo?taskID=52876746 Koji build for Fedora 33: https://koji.fedoraproject.org/koji/taskinfo?taskID=52876923 Koji build for Fedora 32: https://koji.fedoraproject.org/koji/taskinfo?taskID=52877091 Koji build for EPEL8: https://koji.fedoraproject.org/koji/taskinfo?taskID=52877312 Koji build for EPEL7: https://koji.fedoraproject.org/koji/taskinfo?taskID=52877482 ---- This is my first package for Fedora, and I am seeking a sponsor. As instructed on https://pagure.io/packager-sponsors/, I will apply for sponsorship once the package review process is completed for this package. Once the package is in Fedora, I plan to request EPEL branches as well. I have also added the upstream package to release monitoring: https://release-monitoring.org/project/138112/. While I have about a decade of experience with RPM packaging, this has generally not been public work. I offer the following recent contributions to demonstrate my understanding of RPM packaging and of Fedora guidelines and processes. My PR to build rasqal against system libraries (libgcrypt) instead of using bundled cryptographic hash implementations was accepted, resolving a six-year-old issue: https://bugzilla.redhat.com/show_bug.cgi?id=1099251. My PR to unbundle mathjax from spyder was accepted, resolving a seven-year-old issue: https://bugzilla.redhat.com/show_bug.cgi?id=1017213. I fixed a couple of cases where applications showed a generic fallback icon under GNOME/Wayland. In the case of spyder, the correct fix was to make an upstream bug report and supply an upstream PR, which was accepted: https://bugzilla.redhat.com/show_bug.cgi?id=1832579. In the case of boinc-client, the correct fix was a change in the Fedora packaging: https://bugzilla.redhat.com/show_bug.cgi?id=1880553. I have also written a spec file for the SLEEF Vectorized Math Library, which demonstrates my ability to correctly handle more complicated packages than this one: https://gitlab.com/musicinmybrain/sleef-rpm/-/blob/master/sleef.spec. I have not submitted a review request for that package because there are still a few unresolved test failures on the s390x platform. Thanks for your time. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
