https://bugzilla.redhat.com/show_bug.cgi?id=1885684 Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |zbyszek@xxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |zbyszek@xxxxxxxxx Doc Type|--- |If docs needed, set a value Flags| |fedora-review? --- Comment #1 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- Kudos for starting with koji builds on multiple versions! > https://github.com/RadeonOpenCompute/ROC-smi/archive/rocm-%{version}.tar.gz#/ROC-smi-rocm-%{version}.tar.gz We generally don't use the trick with package renaming anymore. It doesn't hurt, but it introduces additional complexity. Package is simple, everything seems straightforward. + package name is OK + latest version + license is acceptable for Fedora (MIT) + license is specified correctly + BR/Requires/Provides look reasonable + builds and installs OK rpmlint: rocm-smi.noarch: W: no-manual-page-for-binary rocm-smi 2 packages and 0 specfiles checked; 0 errors, 1 warnings. Oh, one minor issue: The man page needs to go into %{_mandir}/man1/. That's why rpmlint doesn't find the page. > I have also written a spec file for the SLEEF Vectorized Math Library, which demonstrates my ability to correctly handle more complicated packages than this one: > https://gitlab.com/musicinmybrain/sleef-rpm/-/blob/master/sleef.spec. I have not submitted a review request for that package because there are still a few unresolved test > failures on the s390x platform. Please also submit that. It might be OK to simply exclude the build for s390x or skip the tests... -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
