https://bugzilla.redhat.com/show_bug.cgi?id=1690046 --- Comment #18 from jogas@xxxxxxxx --- > The Release tag says 1, but the %changelog says 2. Oops. Fixed locally. > I don't know what the _libexecdir definition is here, but it should be > removed. The libexecdir macro expands to /usr/lib instead of /usr/libexec on SUSE. The _libexecdir macro was defined to avoid a SUSE conditional. Is there a better solution I am missing? > build_cflags and build_ldflags are always defined now, so the > conditionals for those can be removed. Great! > It might be better to change this to use mv and avoid the %exclude in > %files: > > cp -r %{buildroot}/%{_libexecdir}/%{name} %{buildroot}/%{_libexecdir}/%{name}-%{version} Good point, resolved locally. Re. Documentation: To recap: the primary issue is that we cannot build the documentation without sphinx-build version 1.4.9 or greater. AFAICT, only Fedora29, Fedora30, and Rawhide can satisfy this dependency. Epel provides version 1.1.3. Originally, on epel, your spec file forced the documentation to build by ignoring warnings via: $ make -C doc-src -k || : I initially thought this method built the html files with broken tables. However, upon closer inspection I've learned that the html files are skipped entirely. At this point, I am convinced this the best way to proceed. We build the documentation and on epel, in place of the html files, we can add a readme that directs them to online html documentation. In short we'd have: Fedora flavors: man pages and html docs epel: man pages and readme with a link to online html docs I'd like your blessing before moving forward. If Orion has any thoughts or advice regarding this situation it would be warmly received. > I haven't yet figured out how to run the tests from the installed > package. I think that deserves a README. [...] The test suite location and its usage is unclear. We are addressing this upstream by adding a ch-test wrapper to bin (https://github.com/hpc/charliecloud/pull/447). For now, I will add a readme. As always, I appreciate your time and effort. Thanks Dave. Best, Jordan -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
