https://bugzilla.redhat.com/show_bug.cgi?id=1690046 --- Comment #17 from Dave Love <dave.love@xxxxxxxxxxxxxxxx> --- The fedora-review tool is currently more broken than usual, so I can't do this properly. However, here's a fairly quick semi-manual go at it. The Release tag says 1, but the %changelog says 2. I don't know what the _libexecdir definition is here, but it should be removed. build_cflags and build_ldflags are always defined now, so the conditionals for those can be removed. It might be better to change this to use mv and avoid the %exclude in %files: cp -r %{buildroot}/%{_libexecdir}/%{name} %{buildroot}/%{_libexecdir}/%{name}-%{version} Is there some particular reason for doing it that way? The major issue now is the documentation, I think. That's 11MB, which at least means it should be in a sub-package. However, the bulk of that seems to be bundled fonts. They appear (although I'm not sure) all to be packaged, so the packaged versions should be used. I don't know about possibly unbundling various JavaScript bits, but at least jquery seems to be packaged. I'm not sure generally how that needs to be, or should be handled, e.g. by linking from %_jsdir. Also the currently shipped files have licences other than the ASL 2.0 that's declared by the rpm, which I'd missed in my original packaging. Multiple licences need to be listed in the spec. I haven't yet figured out how to run the tests from the installed package. I think that deserves a README. Is it sensible for the test package to require any packages it might use? Probably it should use some sort of weak dependencies (conditionally, as they're not supported in el7) on things it can use from Fedora. This looks a lot simpler to package than it is on closer inspection! Orion may have more insight to share. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
