[Bug 1690046] Review Request: Charliecloud - unprivileged container runtime

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1690046



--- Comment #19 from Orion Poplawski <orion@xxxxxxxx> ---
(In reply to jogas from comment #18)
> > I don't know what the _libexecdir definition is here, but it should be
> > removed.
> 
> The libexecdir macro expands to /usr/lib instead of /usr/libexec on SUSE.
> The _libexecdir macro was defined to avoid a SUSE conditional. Is there a
> better solution I am missing?

If SUSE expands _libexecdir to /usr/lib, perhaps they really want you to put
your "libexec" files there?  If you want to keep this, put a comment explaining
why it is being defined, and a preferable definition would be:

%{!?_libexecdir:%define _libexecdir %{_exec_prefix}/libexec}

unless SUSE does not define %{_exec_prefix}.

> Re. Documentation:
> 
> To recap: the primary issue is that we cannot build the documentation without
> sphinx-build version 1.4.9 or greater. AFAICT, only Fedora29, Fedora30, and
> Rawhide can satisfy this dependency. Epel provides version 1.1.3.
> 
> Originally, on epel, your spec file forced the documentation to build by
> ignoring warnings via:
> 
> $ make -C doc-src -k || :
> 
> I initially thought this method built the html files with broken tables.
> However, upon closer inspection I've learned that the html files are skipped
> entirely. At this point, I am convinced this the best way to proceed. We
> build
> the documentation and on epel, in place of the html files, we can add a
> readme
> that directs them to online html documentation. In short we'd have:
> 
>     Fedora flavors: man pages and html docs
>     epel: man pages and readme with a link to online html docs
> 
> I'd like your blessing before moving forward. If Orion has any thoughts or
> advice regarding this situation it would be warmly received.

That's fine by me.  Another option is to capture a build of the docs from
Fedora and install that on EPEL.


FYI - I've sponsored Jordan, and will be leaving tomorrow for an extended
vacation.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux