https://bugzilla.redhat.com/show_bug.cgi?id=1680374 Robert-André Mauchin <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |zebob.m@xxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |zebob.m@xxxxxxxxx Flags| |fedora-review? --- Comment #3 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- - %{__perl} → perl - Use: BuildRequires: perl(ExtUtils::MakeMaker) >= 6.76 with perl Makefile.PL INSTALLDIRS=vendor NO_PACKLIST=1 And thus remove: %{_bindir}/find %{buildroot} -type f -name .packlist -exec rm -f {} \; %{_bindir}/find %{buildroot} -depth -type d -exec rmdir {} 2>/dev/null \; - Use NO_PERLLOCAL=1: perl Makefile.PL INSTALLDIRS=vendor NO_PACKLIST=1 NO_PERLLOCAL=1 with %make_install instead of %{__make} pure_install PERL_INSTALL_ROOT=%{buildroot} - Do not package META.json im %files - Add a BR for Perl required version: BuildRequires: perl(:VERSION) >= 5.010 URL and Source addresses are Ok. Source archive (SHA-256: 173192b3989b1e47e606ce9ba2cacc1da3d07de216002931288318eecf8e3ffb) is original. Ok. Summary verified from lib/IO/Prompter.pm. Ok. Description verified from lib/IO/Prompter.pm. Ok. License verified from lib/IO/Prompter.pm and README. Ok. No XS code, noarch BuildArch is Ok. $ rpmlint perl-IO-Prompter.spec review-perl-IO-Prompter/results/perl-IO-Prompter-0.004015-0.2.fc31.noarch.rpm review-perl-IO-Prompter/results/perl-IO-Prompter-0.004015-0.2.fc31.src.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. $ rpm -q -lv -p perl-IO-Prompter-0.004015-0.2.fc31.noarch.rpm drwxr-xr-x 2 root root 0 févr. 24 15:33 /usr/share/doc/perl-IO-Prompter -rw-r--r-- 1 root root 4474 déc. 7 20:53 /usr/share/doc/perl-IO-Prompter/Changes -rw-r--r-- 1 root root 936 déc. 7 20:53 /usr/share/doc/perl-IO-Prompter/META.json -rw-r--r-- 1 root root 1042 déc. 7 20:53 /usr/share/doc/perl-IO-Prompter/README -rw-r--r-- 1 root root 22712 févr. 24 15:33 /usr/share/man/man3/IO::Prompter.3pm.gz drwxr-xr-x 2 root root 0 févr. 24 15:33 /usr/share/perl5/vendor_perl/IO -rw-r--r-- 1 root root 123312 déc. 7 20:53 /usr/share/perl5/vendor_perl/IO/Prompter.pm File permissions and layout are Ok. $ rpm -q --requires -p perl-IO-Prompter-0.004015-0.2.fc31.noarch.rpm | sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.28.1) 1 perl(:VERSION) >= 5.10.0 1 perl(Carp) 1 perl(Contextual::Return) 1 perl(Scalar::Util) 1 perl(strict) 1 perl(Symbol) 1 perl(utf8) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. Add these as BR too: BuildRequires: perl(Carp) BuildRequires: perl(Scalar::Util) BuildRequires: perl(strict) BuildRequires: perl(Symbol) BuildRequires: perl(utf8) BuildRequires: perl(warnings) # Tests BuildRequires: perl(diagnostics) BuildRequires: perl(lib) $ rpm -q --provides -p perl-IO-Prompter-0.004015-0.2.fc31.noarch.rpm perl(IO::Prompter) = 0.004015 perl-IO-Prompter = 0.004015-0.2.fc31 Binary provides are Ok. Package builds in Koji (https://koji.fedoraproject.org/koji/taskinfo?taskID=33010164). Ok Resolution: Package not approved. Please fix all the aforementioned points. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
