https://bugzilla.redhat.com/show_bug.cgi?id=1483262 Robert-André Mauchin <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST CC| |zebob.m@xxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |zebob.m@xxxxxxxxx Flags| |fedora-review+ --- Comment #16 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- LGTM, package approved. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "*No copyright* Expat License", "Unknown or generated", "BSD 2-clause "Simplified" License", "Apache License (v2.0)", "Expat License", "BSD (unspecified)". 1134 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/phpdoc /review-phpdoc/licensecheck.txt [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Macros in Summary, %description expandable at SRPM build time. Note: Macros in: phpdoc (description) [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 143360 bytes in 24 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Avoid bundling fonts in non-fonts packages. Note: Package contains font files [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: phpdoc-2.9.0-7.fc31.noarch.rpm phpdoc-2.9.0-7.fc31.src.rpm phpdoc.noarch: E: explicit-lib-dependency php-zlib phpdoc.noarch: W: spelling-error %description -l en_US formatters -> for matters, for-matters, formatted phpdoc.noarch: W: obsolete-not-provided php-channel-phpdoc phpdoc.noarch: E: useless-provides bundled(js-bootstrap) phpdoc.noarch: E: useless-provides bundled(js-jquery) phpdoc.noarch: E: useless-provides bundled(js-jquery-iviewer) phpdoc.noarch: E: useless-provides bundled(js-jquery-mousewheel) phpdoc.noarch: E: useless-provides bundled(js-jquery-ui) phpdoc.noarch: E: htaccess-file /usr/share/php/phpDocumentor/data/templates/responsive/.htaccess phpdoc.noarch: W: no-manual-page-for-binary phpdoc phpdoc.src: W: spelling-error %description -l en_US formatters -> for matters, for-matters, formatted phpdoc.src:432: W: unversioned-explicit-obsoletes php-channel-phpdoc phpdoc.src:462: W: unversioned-explicit-provides bundled(js-jquery-cookie) phpdoc.src:499: W: unversioned-explicit-provides bundled(css-sencss) phpdoc.src:502: W: unversioned-explicit-provides bundled(js-prism) phpdoc.src:534: W: unversioned-explicit-provides bundled(js-prettify) phpdoc.src:543: W: unversioned-explicit-provides bundled(glyphicons-halflings) phpdoc.src: W: invalid-url Source0: phpdoc-2.9.0-be607da0eef9b9249c43c5b4820d25d631c73667.tar.gz 2 packages and 0 specfiles checked; 6 errors, 12 warnings. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
