https://bugzilla.redhat.com/show_bug.cgi?id=1680376 Robert-André Mauchin <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |zebob.m@xxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |zebob.m@xxxxxxxxx Flags| |fedora-review? --- Comment #3 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- - %{__perl} → perl - Use: BuildRequires: perl(ExtUtils::MakeMaker) >= 6.76 with perl Makefile.PL INSTALLDIRS=vendor NO_PACKLIST=1 And thus remove: %{_bindir}/find %{buildroot} -type f -name .packlist -exec rm -f {} \; %{_bindir}/find %{buildroot} -depth -type d -exec rmdir {} 2>/dev/null \; - Use NO_PERLLOCAL=1: perl Makefile.PL INSTALLDIRS=vendor NO_PACKLIST=1 NO_PERLLOCAL=1 with %make_install instead of %{__make} pure_install PERL_INSTALL_ROOT=%{buildroot} - Do not package dist.ini im %files URL and Source addresses are Ok. Source archive (SHA-256: 131f0689b2b42b1b31449714c6eda8f811dd96a7c86748f1e03b239cfd0121c0) is original. Ok. Summary verified from lib/Log/Any/Adapter/TAP.pm. Ok. Description verified from lib/Log/Any/Adapter/TAP.pm. Ok. License verified from lib/Log/Any/Adapter/TAP.pm and README. Ok. No XS code, noarch BuildArch is Ok. $ rpmlint perl-Log-Any-Adapter-TAP.spec review-perl-Log-Any-Adapter-TAP/results/perl-Log-Any-Adapter-TAP-0.003003-0.2.fc31.noarch.rpm review-perl-Log-Any-Adapter-TAP/results/perl-Log-Any-Adapter-TAP-0.003003-0.2.fc31.src.rpm perl-Log-Any-Adapter-TAP.noarch: W: spelling-error Summary(en_US) testcases -> test cases, test-cases, suitcases perl-Log-Any-Adapter-TAP.noarch: W: spelling-error %description -l en_US testcases -> test cases, test-cases, suitcases perl-Log-Any-Adapter-TAP.noarch: W: spelling-error %description -l en_US diag -> jag, dig, dag perl-Log-Any-Adapter-TAP.src: W: spelling-error Summary(en_US) testcases -> test cases, test-cases, suitcases perl-Log-Any-Adapter-TAP.src: W: spelling-error %description -l en_US testcases -> test cases, test-cases, suitcases perl-Log-Any-Adapter-TAP.src: W: spelling-error %description -l en_US diag -> jag, dig, dag 2 packages and 1 specfiles checked; 0 errors, 6 warnings. . $ rpm -q -lv -p perl-Log-Any-Adapter-TAP-0.003003-0.2.fc31.noarch.rpm drwxr-xr-x 2 root root 0 févr. 24 15:50 /usr/share/doc/perl-Log-Any-Adapter-TAP -rw-r--r-- 1 root root 1910 févr. 13 2016 /usr/share/doc/perl-Log-Any-Adapter-TAP/Changes -rw-r--r-- 1 root root 392 févr. 13 2016 /usr/share/doc/perl-Log-Any-Adapter-TAP/README -rw-r--r-- 1 root root 811 févr. 13 2016 /usr/share/doc/perl-Log-Any-Adapter-TAP/dist.ini drwxr-xr-x 2 root root 0 févr. 24 15:50 /usr/share/licenses/perl-Log-Any-Adapter-TAP -rw-r--r-- 1 root root 18355 févr. 13 2016 /usr/share/licenses/perl-Log-Any-Adapter-TAP/LICENSE -rw-r--r-- 1 root root 3460 févr. 24 15:50 /usr/share/man/man3/Log::Any::Adapter::TAP.3pm.gz drwxr-xr-x 2 root root 0 févr. 24 15:50 /usr/share/perl5/vendor_perl/Log drwxr-xr-x 2 root root 0 févr. 24 15:50 /usr/share/perl5/vendor_perl/Log/Any drwxr-xr-x 2 root root 0 févr. 24 15:50 /usr/share/perl5/vendor_perl/Log/Any/Adapter -rw-r--r-- 1 root root 13949 févr. 13 2016 /usr/share/perl5/vendor_perl/Log/Any/Adapter/TAP.pm File permissions and layout are Ok. $ rpm -q --requires -p perl-Log-Any-Adapter-TAP-0.003003-0.2.fc31.noarch.rpm | sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.28.1) 1 perl(Carp) 1 perl(Data::Dumper) 1 perl(Log::Any) 1 perl(Log::Any::Adapter::Base) 1 perl(parent) 1 perl(Scalar::Util) 1 perl(strict) 1 perl(Try::Tiny) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. Add BR for tests: BuildRequires: perl(TestLogging) BuildRequires: perl(Test::Pod::Coverage) >= 1.08 BuildRequires: perl(Pod::Coverage::TrustPod) rpm -q --provides -p perl-Log-Any-Adapter-TAP-0.003003-0.2.fc31.noarch.rpm perl(Log::Any::Adapter::TAP) = 0.003003 perl-Log-Any-Adapter-TAP = 0.003003-0.2.fc31 Binary provides are Ok. Package builds in Koji (https://koji.fedoraproject.org/koji/taskinfo?taskID=33010459). Ok Resolution: Package not approved. Please fix all the aforementioned points. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
