[Bug 1680374] Review Request: perl-IO-Prompter - Prompt for input, read it, clean it, return it

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1680374



--- Comment #4 from Björn 'besser82' Esser <besser82@xxxxxxxxxxxxxxxxx> ---
Thank you for the review!


(In reply to Robert-André Mauchin from comment #3)
>  - %{__perl} → perl

I think that is a matter of personal preference.

Your other remarks have been addressed.

***

=== Updated package ===

Changelog:

  * Sun Feb 24 2019 Björn Esser <besser82@xxxxxxxxxxxxxxxxx> - 0.004015-0.2
- Changes as suggested in review (#1680374)
- Add a BR for Perl required version
- Add a set of explicit BuildRequires
- Use %%make_install
- Drop cleanups using find
- Drop META.json fom %%doc


Urls:

  Spec URL: 
https://pagure.io/besser82/package-review/raw/master/f/perl-IO-Prompter.spec
  SRPM URL: 
https://pagure.io/besser82/package-review/raw/master/f/perl-IO-Prompter-0.004015-0.3.fc31.src.rpm


Scratch build (rawhide):

  https://koji.fedoraproject.org/koji/taskinfo?taskID=33010978

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux