https://bugzilla.redhat.com/show_bug.cgi?id=1302003 --- Comment #12 from gil cattaneo <puntogil@xxxxxxxxx> --- (In reply to Christos Triantafyllidis from comment #11) > (In reply to gil cattaneo from comment #10) > > (In reply to Christos Triantafyllidis from comment #9) > > > I'm not sure how to test this. Would it be possible to provide a test case? > > > I'd like to run a simple test run especially given the fact that %check is > > > not included. > > maven build style not use and do not need the %check section > > I understand that this may not be used but I have no way to ensure that this > package actually does what it is supposed to do. Is there a simple unit test > I can use to cross-check it? If that requires mongo servers etc that is > something that I cannot test. MongoDB stuff in this case is useless, we can't run test suite > > > [!]: Fully versioned dependency in subpackages if applicable. > > > Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in mongo- > > > java-driver2-javadoc > > > > No needed is a noarch package > > Not sure how the build arch relates to that. That more or less means that > whenever the mongo-java-driver2-javadoc it should pull mongo-java-driver2 > too. Both packages are noarch. Why i should use ISA notation? No have sense for me > > > > > > I also see that compared to the original package the following subpackages > > > are missing: > > > mongo-java-driver2-bson > > > mongo-java-driver2-bson-javadoc > > not needed > > Does this package provide also the bson package functionality? If not then > it won't be a 100% compat package. Excuse the fact that I have minimal java > knowledge, does that mean that no-one would ever need those bson subpackages? Original mongo-java-driver spec file use ant build style, and split the library in two artifacts. With maven both libraries are contained in the same JAR file As compact package this work fine, for me. > > > Also another thing that is not clear to me is why the SPEC file of > > > mongo-java-driver is not used as a base for this given that the aim of a > > > compat package should be to have the exactly the same functionality as the > > > initial one that got updated. > > > > It is not necessary > Yes but it would just make the SPEC preperation and the review much easier :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review