https://bugzilla.redhat.com/show_bug.cgi?id=1302003 Christos Triantafyllidis <christos.triantafyllidis@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #13 from Christos Triantafyllidis <christos.triantafyllidis@xxxxxxxxx> --- (In reply to gil cattaneo from comment #12) > (In reply to Christos Triantafyllidis from comment #11) > > (In reply to gil cattaneo from comment #10) > > > (In reply to Christos Triantafyllidis from comment #9) > > > > I'm not sure how to test this. Would it be possible to provide a test case? > > > > I'd like to run a simple test run especially given the fact that %check is > > > > not included. > > > maven build style not use and do not need the %check section > > > > I understand that this may not be used but I have no way to ensure that this > > package actually does what it is supposed to do. Is there a simple unit test > > I can use to cross-check it? If that requires mongo servers etc that is > > something that I cannot test. > > MongoDB stuff in this case is useless, we can't run test suite Agreed. > > > > > [!]: Fully versioned dependency in subpackages if applicable. > > > > Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in mongo- > > > > java-driver2-javadoc > > > > > > No needed is a noarch package > > > > Not sure how the build arch relates to that. That more or less means that > > whenever the mongo-java-driver2-javadoc it should pull mongo-java-driver2 > > too. > > Both packages are noarch. Why i should use ISA notation? No have sense for me > The ISA notation is not the point here. The point was that mongo-java-driver2-javadoc doesn't have mongo-java-driver2 in its requires. I checked again the mongo-java-driver-javadoc and I see that this is not the case for it too so we can skip that too. > > > > > > > > I also see that compared to the original package the following subpackages > > > > are missing: > > > > mongo-java-driver2-bson > > > > mongo-java-driver2-bson-javadoc > > > not needed > > > > Does this package provide also the bson package functionality? If not then > > it won't be a 100% compat package. Excuse the fact that I have minimal java > > knowledge, does that mean that no-one would ever need those bson subpackages? > > Original mongo-java-driver spec file use ant build style, and split the > library in two artifacts. With maven both libraries are contained in the > same JAR file > As compact package this work fine, for me. > Agreed. Thanks for clarifying. I'm marking the review as completed. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review